-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #25
Conversation
Allow use of legacy device definition through exposes functionality
const dev_block = $(this).parents('div.device'); | ||
const id = getDevId(dev_block); | ||
const name = getDevName(dev_block); | ||
toggleDebugDevice(id, name); |
Check warning
Code scanning / CodeQL
Superfluous trailing arguments Warning
function toggleDebugDevice
async function toggleDebugDevice(id) { | ||
sendTo(namespace, 'setDeviceDebug', {id:id}, function (msg) { | ||
sendTo(namespace, 'getDebugDevices', {}, function(msg) { | ||
if (msg && typeof (msg.debugDevices == 'array')) { |
Check warning
Code scanning / CodeQL
Useless conditional Warning
|
||
async function selectImageOverride(id) { | ||
const dev = devices.find((d) => d._id == id); | ||
let localImages = undefined; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
admin/admin.js
Outdated
|
||
function getDevices() { | ||
getCoordinatorInfo(); | ||
sendTo(namespace, 'getDebugDevices', {}, function(msg) { | ||
if (msg && typeof (msg.debugDevices == 'array')) { |
Check warning
Code scanning / CodeQL
Useless conditional Warning
excludes.forEach(id => { | ||
// const b = devices.find((item) => item._id.contains(id)); | ||
const exclude_id = id.key; | ||
const exclude_icon = id.value; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
} | ||
|
||
verifyDeviceName(id, name) { | ||
const savedId = id.replace(`${this.adapter.namespace}.`, ''); |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
lib/statescontroller.js
Outdated
} | ||
if (!devStates) { | ||
if (has_debug) this.error(`ELEVATED IE2: no device states for device ${devId} type '${model}'`) | ||
if (has_elevated_debug) | ||
this.elevatedMessage(devId, `ELEVATED IE02: no device states for device ${devId} type '${model}'`, true) |
Check notice
Code scanning / CodeQL
Semicolon insertion Note
the enclosing function
lib/statescontroller.js
Outdated
@@ -622,6 +715,7 @@ | |||
for (const stateInd in states) { | |||
const statedesc = states[stateInd]; | |||
let value; | |||
let extra_value = undefined; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
lib/zbDeviceAvailability.js
Outdated
try { | ||
this.warn(`Pinging '${ieeeAddr}' (${device.modelID})`) |
Check notice
Code scanning / CodeQL
Semicolon insertion Note
the enclosing function
await this.herdsman.stop(); | ||
} | ||
catch (error) { | ||
this.warn(`Starting zigbee-herdsman problem : ${error && error.message ? error.message : 'no error message'}`) |
Check notice
Code scanning / CodeQL
Semicolon insertion Note
No description provided.