Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builder fixes #93

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Builder fixes #93

merged 2 commits into from
Aug 24, 2023

Conversation

Vel1khan
Copy link
Collaborator

@Vel1khan Vel1khan commented Aug 21, 2023 •
edited
Loading

  • Also use the Build-Jdk entry in Manifest.MF to determine the JDK compiler version. If not available, build with all LTS versions up to the latest version at the publish date of the package.
  • If newline has been found by the analyzer, only build with that newline character

Address this later:

@Vel1khan
worked on package builder. build-jdk manifest entry now used for buil…
85e5eb2 
…ding. if build-jdk-spec and build-jdk not present, build with all LTS versions available at publish date
@Vel1khan
integrated newline build param from extractor + small refactoring
2f9703b
@Vel1khan Vel1khan marked this pull request as draft August 21, 2023 18:00
@Vel1khan Vel1khan linked an issue Aug 21, 2023 that may be closed by this pull request
Extract jdk version from class files #85
Closed
@Vel1khan Vel1khan mentioned this pull request Aug 23, 2023
Closed
10 tasks
@Vel1khan Vel1khan self-assigned this Aug 24, 2023
@Vel1khan Vel1khan marked this pull request as ready for review August 24, 2023 12:08
@Vel1khan Vel1khan merged commit ff07e42 into dev Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Vel1khan Vel1khan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract jdk version from class files
1 participant
@Vel1khan