Fix no valid test when sharding #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cd77749.
|
ah this makes sense now, saw this error just today and was perplexed about it. Thanks for reporting and putting in a fix @fellen31 |
|
Thank you Felix! 🙏🚀 |
|
Any idea on when this will be in a release? 😁 |
|
Tomorrow 🙌 |
|
Done 🚀 |
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testSuits.isEmpty()check so that shards with no tests do not result in an error.Executed 1 tests. 1 tests failed. Done!message.java.lang.IllegalArgumentException: Input list cannot be null or emptywhen running with a nonexistent tag (resulting in no tests) together with sharding.