Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid pre-commit tag in README example #56

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

kieran-ryan
Copy link
Collaborator

The present pre-commit example contains an invalid git tag for removestar resulting in the following error.

An unexpected error has occurred: CalledProcessError: command: ('/usr/local/bin/git', 'checkout', 'v1.4')
return code: 1
stdout: (none)
stderr:
    error: pathspec 'v1.4' did not match any file(s) known to git
Check the log at /Users/KieranRyan/.cache/pre-commit/pre-commit.log

removestar does not use the 'v' prefix in its tag names. Thus, updating the README tag version to reflect.

@kieran-ryan kieran-ryan added the bug Something isn't working label Jan 21, 2024
@kieran-ryan kieran-ryan self-assigned this Jan 21, 2024
@kieran-ryan kieran-ryan changed the title fix: valid tag for pre-commit in README Valid recommit tag in README example Jan 21, 2024
@kieran-ryan kieran-ryan changed the title Valid recommit tag in README example Valid precommit tag in README example Jan 21, 2024
@kieran-ryan kieran-ryan changed the title Valid precommit tag in README example Valid pre-commit tag in README example Jan 21, 2024
Copy link
Collaborator

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my bad. Thanks, @kieran-ryan!

@kieran-ryan kieran-ryan merged commit 4bdd3f9 into master Jan 22, 2024
7 checks passed
@kieran-ryan kieran-ryan deleted the pre-commit-example-tag branch January 22, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants