Skip to content

Commit

Permalink
chore: bump rules_js dep to 1.29.2 to pickup Windows fix (#83)
Browse files Browse the repository at this point in the history
  • Loading branch information
gregmagolan authored Jul 4, 2023
1 parent d143f49 commit 85d3b8b
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
5 changes: 3 additions & 2 deletions MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@ bazel_dep(name = "bazel_skylib", version = "1.3.0")
# Need #397 to skip stardoc targets
bazel_dep(name = "aspect_bazel_lib", version = "1.30.2")

# Need attribute 'dev' in 'npm_package_store_internal' rule
bazel_dep(name = "aspect_rules_js", version = "1.19.0")
# 1.19.0: Need attribute 'dev' in 'npm_package_store_internal' rule
# 1.29.2: Need Windows fix to disable fs patches
bazel_dep(name = "aspect_rules_js", version = "1.29.2")
bazel_dep(name = "rules_nodejs", version = "5.5.3")
bazel_dep(name = "platforms", version = "0.0.5")

Expand Down
2 changes: 1 addition & 1 deletion e2e/smoke/MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

bazel_dep(name = "aspect_rules_rollup", version = "0.0.0", dev_dependency = True)
bazel_dep(name = "bazel_skylib", version = "1.3.0", dev_dependency = True)
bazel_dep(name = "aspect_rules_js", version = "1.24.1", dev_dependency = True)
bazel_dep(name = "aspect_rules_js", version = "1.29.2", dev_dependency = True)

local_path_override(
module_name = "aspect_rules_rollup",
Expand Down
6 changes: 3 additions & 3 deletions rollup/dependencies.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ def rules_rollup_dependencies():

http_archive(
name = "aspect_rules_js",
sha256 = "4722264788b92aeca47bf108c5909d94720114d73739e3cff9f48a10b18ef8cd",
strip_prefix = "rules_js-1.25.0",
url = "https://github.com/aspect-build/rules_js/releases/download/v1.25.0/rules_js-v1.25.0.tar.gz",
sha256 = "7cb2d84b7d5220194627c9a0267ae599e357350e75ea4f28f337a25ca6219b83",
strip_prefix = "rules_js-1.29.2",
url = "https://github.com/aspect-build/rules_js/releases/download/v1.29.2/rules_js-v1.29.2.tar.gz",
)

http_archive(
Expand Down

0 comments on commit 85d3b8b

Please sign in to comment.