bazel: use short_path with entry_points #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change bazel will pass the full qualified name like k8-fastbuild/bin/<package> which but rollup is being called from k8-fastbuild/bin so it can't resolve properly
|
Can you try adding a test that fails without the change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change bazel will pass the full qualified name like k8-fastbuild/bin/ which but rollup is being called from k8-fastbuild/bin so it can't resolve properly
I noticed the repo has not tests for multiple entry_point that's why it has gone unnoticed
Changes are visible to end-users: yes
I think end-users where not able to use the module before at all
Searched for relevant documentation and updated as needed: yes
Breaking change (forces users to change their own code or config): no (don't think so)
Suggested release notes appear below: yes
Manual testing; please provide instructions so we can reproduce: Tested into our monorepo, we have a ts_project that generates a bunch of js files, then we pass those as entry_points to rollup_bundle
If required I could try to setup a unit test