feat: docker-based benchmarks comparing OpenSSL perf #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeagleGross
changed the title
DeagleGross
requested review from
BrennanConroy,
adityamandaleeka and
sebastienros
DeagleGross
commented
Jan 23, 2025
BrennanConroy
approved these changes
Jan 29, 2025
| @@ -219,4 +223,25 @@ static IPEndPoint CreateIPEndPoint(UrlPrefix urlPrefix) | |||
| } | |||
|
|
|||
| return protocols; | |||
| } | |||
|
|
|||
| static void LogOpenSSLVersion() | |||
There was a problem hiding this comment.
Looks like this code runs no matter what OS? Should probably check you're on linux?
There was a problem hiding this comment.
added check that we are on linux or macos
…m/DeagleGross/Benchmarks into dmkorolev/idna/openssl-versioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we have heard OpenSSL 3.x.x has a perf degradation comparing OpenSSL 1.1.1.
It is critical to understand if there is a bottleneck in the OpenSSL package itself, that is why I packed app used in previously set up benchmarks into docker containers. Now we would be able to compare performance differing the OpenSSL package version easily.
example:
results that I got: