Unit tests for PR 450 (temporalio#611)

* Add unit tests for temporalio#450.
asproul · Dec 16, 2024 · 0bf4c6f · 0bf4c6f
1 parent 223d752
commit 0bf4c6f
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/charts/temporal/templates/admintools-deployment.yaml b/charts/temporal/templates/admintools-deployment.yaml
@@ -24,7 +24,7 @@ spec:
       {{ include "temporal.serviceAccount" $ }}
       {{- if $.Values.admintools.additionalInitContainers }}
       initContainers:
-        {{- toYaml $.Values.admintools.additionalInitContainers | nindent 8}}
+        {{- toYaml $.Values.admintools.additionalInitContainers | nindent 8 }}
       {{- end }}
       containers:
         - name: admin-tools

diff --git a/charts/temporal/templates/server-job.yaml b/charts/temporal/templates/server-job.yaml
@@ -146,7 +146,7 @@ spec:
           env:
             - name: TEMPORAL_ADDRESS
               value: "{{ include "temporal.fullname" $ }}-frontend.{{ $.Release.Namespace }}.svc:{{ $.Values.server.frontend.service.port }}"
-              {{- with $.Values.server.additionalVolumeMounts }}
+              {{- with $.Values.admintools.additionalVolumeMounts }}
           volumeMounts:
                 {{- toYaml . | nindent 12 }}
               {{- end }}

diff --git a/charts/temporal/tests/server_deployment_test.yaml b/charts/temporal/tests/server_deployment_test.yaml
@@ -52,3 +52,17 @@ tests:
       - equal:
           path: spec.template.spec.containers[0].resources.requests.cpu
           value: 200m
+  - it: includes additional init containers
+    template: templates/server-deployment.yaml
+    documentSelector:
+      path: .kind
+      value: Deployment
+      matchMany: true
+    set:
+      server:
+        additionalInitContainers:
+          - name: my-init-container
+    asserts:
+      - equal:
+          path: spec.template.spec.initContainers[0].name
+          value: my-init-container