stream: Add functions to get/set fields of Stream #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asticode
requested changes
Jan 13, 2025
stream.go
Outdated
| @@ -120,3 +130,15 @@ func (s *Stream) TimeBase() Rational { | |||
| func (s *Stream) SetTimeBase(r Rational) { | |||
| s.c.time_base = r.c | |||
| } | |||
|
|
|||
| type PTSWrapBits int | |||
There was a problem hiding this comment.
Can you remove this type? No need for it, you can use the int type directly
There was a problem hiding this comment.
Can you add tests as well here for all getters/setters you've added, ordered alphabetically in the form
s1.SetEventFlags(1)
require.Equal(t, 1, s1.EventFlags())
xaionaro
force-pushed
the
feature/stream_get_set_fields
branch
from
18a9855 to
b3e7034
Compare
|
Thanks again for the PR! ❤️ Let me know whether you need a tag 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adding few missing Getters/Setters to
Stream.