Generate CI runners for build matrix dynamically #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
commented
Jan 7, 2025
Comment on lines
+241
to
+247
| # If only free runners are allowed, reduce to a subset | ||
| if args.free_runners: | ||
| runners = { | ||
| runner: runner_config | ||
| for runner, runner_config in runners.items() | ||
| if runner_config.get("free") | ||
| } |
There was a problem hiding this comment.
We can hook this up for forks, #431
zanieb
commented
Jan 7, 2025
Comment on lines
+164
to
+166
| # If `run` is in the config, use that — otherwise, default to if the | ||
| # runner architecture matches the build architecture | ||
| "run": str(config.get("run", runners[runner]["arch"] == arch)).lower(), |
There was a problem hiding this comment.
Once we do #431, we might not have access to the runners needed for run. We'll have to do something a bit more complicated for PGO targets in that case but I don't handle this here.
zanieb
commented
Jan 7, 2025
Comment on lines
+8
to
+12
| # TODO: Enable this runner to perform native builds for aarch64 | ||
| # depot-ubuntu-22.04-arm: | ||
| # arch: aarch64 | ||
| # platform: linux | ||
| # free: false |
There was a problem hiding this comment.
Next, I'm going to try to enable PGO on aarch64 linux with this runner
charliermarsh
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.