Skip to content
This repository has been archived by the owner on Jun 8, 2024. It is now read-only.

ci: 👷 Update Rust toolchain version #157

Merged
merged 2 commits into from
Feb 29, 2024
Merged

ci: 👷 Update Rust toolchain version #157

merged 2 commits into from
Feb 29, 2024

Conversation

TeddyHuang-00
Copy link
Contributor

Update rust toolchain version to the latest stable. Should solve the issue #156

Side note: I think this might be better than pinning the toolchain version to a specific number. If it is so with other concerns, I shall change that back to something like 1.76.0 which should also work in theory

@TeddyHuang-00
Copy link
Contributor Author

Also updated the rust-version in Cargo.toml to 1.74.0, as clap_lex v0.7.0 requires for at least, as shown in the error message of https://github.com/astrale-sharp/typstfmt/actions/runs/8081248062/job/22079369708#step:4:94

@astrale-sharp
Copy link
Owner

Hey there and thanks :)

I think we had somewhat the intention of staying in sync with typst for some reason, opinions @arnaudgolfouse ?

That being said, I don't see a real reason to do that and so I'm in favor of merging this as is.

@TeddyHuang-00
Copy link
Contributor Author

Well in that case there are still two good reasons:

  1. Typst's release workflow also uses stable Rust toolchain: https://github.com/typst/typst/blob/5a03c818c8b595c9bb62613c8da6d7464ccff05c/.github/workflows/release.yml#L40
  2. Typst's Cargo toml also set rust-version to 1.74.0: https://github.com/typst/typst/blob/5a03c818c8b595c9bb62613c8da6d7464ccff05c/Cargo.toml#L8

In short this is pretty well-aligned with Typst settings.

@astrale-sharp astrale-sharp merged commit 8607206 into astrale-sharp:main Feb 29, 2024
1 check passed
@astrale-sharp
Copy link
Owner

Color me convinced then, thanks for your interest and contribution!

I'm merging this, may I ask what motivated you to do this specific contribution? :)

@TeddyHuang-00
Copy link
Contributor Author

TeddyHuang-00 commented Feb 29, 2024

I'm merging this, may I ask what motivated you to do this specific contribution? :)

Thank you for your fabulous work! I am a huge fan of Typst, where typstfmt is doing a lot of help for me. The direct reason for this PR is that I am maintaining typstfmt-bin on AUR and found out that the the new version doesn't come with linux binaries, so I just dig a little bit to see what I can help 😄

@astrale-sharp
Copy link
Owner

Oh that's lovely :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants