Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add monitoring for PragmaV2 EVM contract #44

Merged
merged 35 commits into from
Oct 24, 2024
Merged

Conversation

azurwastaken
Copy link
Contributor

Resolve : #42

@azurwastaken azurwastaken marked this pull request as ready for review October 10, 2024 15:59
@azurwastaken azurwastaken requested a review from akhercha October 10, 2024 16:00
Copy link
Member

@akhercha akhercha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comms

evm_config.yaml Outdated Show resolved Hide resolved
src/processing/evm.rs Outdated Show resolved Hide resolved
src/processing/evm.rs Show resolved Hide resolved
src/processing/evm.rs Outdated Show resolved Hide resolved
src/processing/evm.rs Outdated Show resolved Hide resolved
src/processing/evm.rs Outdated Show resolved Hide resolved
@azurwastaken azurwastaken requested a review from akhercha October 11, 2024 15:19
.env.example Show resolved Hide resolved
src/processing/evm.rs Outdated Show resolved Hide resolved
src/processing/evm.rs Outdated Show resolved Hide resolved
src/processing/evm.rs Outdated Show resolved Hide resolved
src/processing/evm.rs Outdated Show resolved Hide resolved
src/processing/evm.rs Outdated Show resolved Hide resolved
src/processing/evm.rs Outdated Show resolved Hide resolved
src/processing/evm.rs Outdated Show resolved Hide resolved
src/processing/evm.rs Outdated Show resolved Hide resolved
src/processing/evm.rs Outdated Show resolved Hide resolved
src/processing/evm.rs Outdated Show resolved Hide resolved
evm_config.yaml Outdated Show resolved Hide resolved
src/processing/evm.rs Outdated Show resolved Hide resolved
Copy link
Member

@akhercha akhercha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@akhercha akhercha requested a review from EvolveArt October 11, 2024 17:45
#[allow(missing_docs)]
#[sol(rpc)]
Pragma,
"abi/Pragma.json"
Copy link
Member

@akhercha akhercha Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the ABI from the code and instead just define the interface of the functions we are calling, example here:
https://github.com/astraly-labs/pragma-monorepo/blob/dev/more_networks/rust/theoros/src/rpc/evm/hyperlane.rs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gud

@azurwastaken azurwastaken requested a review from akhercha October 22, 2024 09:21
Copy link
Member

@akhercha akhercha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvolveArt EvolveArt merged commit c8fce24 into main Oct 24, 2024
4 checks passed
@EvolveArt EvolveArt deleted the feat/EVMMonitoring branch October 24, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: add evm support for monitoring
3 participants