Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate cubic memory overhead in generate_precomputes docstring #257

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

matt-graham
Copy link
Collaborator

Resolves #246

@matt-graham matt-graham added the documentation Improvements or additions to documentation label Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.07%. Comparing base (8f6e4d5) to head (bfc9a39).
Report is 39 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #257   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files          31       31           
  Lines        3565     3565           
=======================================
  Hits         3425     3425           
  Misses        140      140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@CosmoMatt CosmoMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable (and correct of course). We really were a little too lax on the numpy development, again the reason (excuse) being that our focus was on the JAX side of things!

@matt-graham matt-graham merged commit 5c94d71 into main Dec 18, 2024
13 checks passed
@matt-graham matt-graham deleted the mmg/document-cubic-generate-precomputes branch December 18, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NumPy generate_precomputes implementation has cubic in L memory overhead
2 participants