Move DbtRunner related functions into dbt/runner.py module
#1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sunny-pastelito-5ecb04 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying astronomer-cosmos with
|
| Latest commit: |
006cc1d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6ef0ef85.astronomer-cosmos.pages.dev |
| Branch Preview URL: | https://issue-865-refactor.astronomer-cosmos.pages.dev |
tatiana
force-pushed
the
issue-865-refactor
branch
from
4afa986 to
0f9f35e
Compare
tatiana
changed the title
DbtRunner utility functions into dbt/runner.py moduleDbtRunner-related functions into dbt/runner.py module
dosubot
bot
added
size:L
tatiana
changed the title
DbtRunner-related functions into dbt/runner.py moduleDbtRunner related functions into dbt/runner.py module
pankajkoti
approved these changes
Jan 22, 2025
tatiana
force-pushed
the
issue-865-refactor
branch
from
52fcba4 to
a7b49b3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1480 +/- ##
==========================================
+ Coverage 96.57% 96.60% +0.03%
==========================================
Files 73 74 +1
Lines 4374 4414 +40
==========================================
+ Hits 4224 4264 +40
Misses 150 150 ☔ View full report in Codecov by Sentry. |
pankajastro
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, @jbandoro added support for Cosmos to use
dbtRunnerto execute dbt commands in the Airflow worker nodes when usingExecutionMode.LOCALinstead of Python's subprocess #850. This change significantly improved Cosmos resource utilisation in worker nodes.The first step to implementing support to use
dbtRunnerduring DAG parsing (ticket #865) when usingLoadMode.DBT_LSis to extractdbtRunnermethods somewhere it can be reused bygraph.pyand is not specific tooperators.py.This PR does the following:
dbt/runner.pydbtRunnerrelated functions to this module, refactoring them as neededoperators/local.pyto use the newly introduced methodsRelated: #865