Allow users to opt-out dbtRunner during DAG parsing
#1495
Merged
+121
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatiana
changed the title
dbtRunner during DAG parsing
✅ Deploy Preview for sunny-pastelito-5ecb04 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying astronomer-cosmos with
|
| Latest commit: |
699db27
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bb12c50c.astronomer-cosmos.pages.dev |
| Branch Preview URL: | https://opt-out-dbtrunner-in-dbt-ls.astronomer-cosmos.pages.dev |
dosubot
bot
added
size:M
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1495 +/- ##
=======================================
Coverage 97.05% 97.05%
=======================================
Files 77 77
Lines 4483 4484 +1
=======================================
+ Hits 4351 4352 +1
Misses 132 132 ☔ View full report in Codecov by Sentry. |
pankajkoti
approved these changes
Jan 29, 2025
pankajastro
approved these changes
Jan 29, 2025
dosubot
bot
added
size:L
|
Thanks for the feedback, @pankajastro & @pankajkoti ! I've added a breaking change notice in the changelog: 14b0a2c As well as docs in 53429d9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While speaking to a customer about #1484, they mentioned they have the following setup:
dbt-databricksinstalled in the same Python virtualenv as Cosmos/Airflowdbt-bigqueryinstalled in a separate Python virtualenv using Astro DockerfileAnd run DAGs using both with the same image. This means 1.9.0a3 breaks them since they use
LoadMode.DBT_LSand onlydebt-data brickscan be parsed. This means that we have to add support to allow users to opt-in / out of using thedbtRunnerduring DAG parsing - similar to what was done for task execution, inExecutionConfig.