Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a naive sparse histogram. #463

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Use a naive sparse histogram. #463

merged 3 commits into from
Jan 6, 2025

Conversation

delucchi-cmu
Copy link
Contributor

We really just need the non-zero indexes and non-zero values, and the complexity of the general scipy sparse array is adding a lot of compute overhead, primarily in the catalog import "Binning" stage.

astronomy-commons/hats#446

@delucchi-cmu delucchi-cmu merged commit ca4700f into main Jan 6, 2025
8 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/453/histogram branch January 6, 2025 15:47
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.57%. Comparing base (1aa15a8) to head (c559473).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
- Coverage   94.59%   94.57%   -0.02%     
==========================================
  Files          28       28              
  Lines        1627     1622       -5     
==========================================
- Hits         1539     1534       -5     
  Misses         88       88              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants