Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move existing catalog check. #466

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

See also #459 and #464

Moves check for existing valid catalog to earlier in the argument checks.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.57%. Comparing base (c3fb952) to head (cdf64f8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #466      +/-   ##
==========================================
- Coverage   94.59%   94.57%   -0.03%     
==========================================
  Files          28       28              
  Lines        1627     1621       -6     
==========================================
- Hits         1539     1533       -6     
  Misses         88       88              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gitosaurus gitosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And thanks.

@delucchi-cmu delucchi-cmu merged commit bacabec into main Jan 6, 2025
10 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/459/valid_existing branch January 6, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants