Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join info from parquet metadata #171

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Join info from parquet metadata #171

merged 2 commits into from
Nov 22, 2023

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Addresses two points in issue #147:

  • Load partition info from _metadata file by default (for association catalog)
  • Don't require partition_info.csv file for catalog to be loaded from disk (for association catalog)

Copy link

github-actions bot commented Nov 22, 2023

Before [5edcb74] After [9e8b1c1] Ratio Benchmark (Parameter)
94.5±0.5ms 97.0±1ms 1.03 benchmarks.time_test_cone_filter_multiple_order
650±10ms 645±4ms 0.99 benchmarks.Suite.time_pixel_tree_creation
117±0.4ms 116±1ms 0.99 benchmarks.time_test_alignment_even_sky

Click here to view all benchmarks.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5edcb74) 100.00% compared to head (e667a24) 99.69%.

Files Patch % Lines
...catalog/association_catalog/association_catalog.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #171      +/-   ##
===========================================
- Coverage   100.00%   99.69%   -0.31%     
===========================================
  Files           49       49              
  Lines         1631     1650      +19     
===========================================
+ Hits          1631     1645      +14     
- Misses           0        5       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu
Copy link
Contributor Author

This PR results in a drop in coverage, but the lines that aren't covered are ones that will be removed once this issue's migration is complete. I'm fine with leaving them uncovered, if My Gracious Reviewer is also ok with that.

Copy link
Contributor

@camposandro camposandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, @delucchi-cmu! I just left a couple of comments regarding the docstrings.

@delucchi-cmu delucchi-cmu merged commit 430aee3 into main Nov 22, 2023
8 of 10 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/147/joins branch November 22, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants