Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim some cloud tests. #176

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Trim some cloud tests. #176

merged 2 commits into from
Dec 1, 2023

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Addresses the first few objectives on issue #175.

  • the data hosted in abfs has been updated with the new _metadata files, and doesn't have any partition_info.csv files
  • updated script to only copy the /tests/data directories that are used in cloud_tests tests.
  • I took out most of the tests, since we're exercising the same code multiple times, and in many cases, not adding coverage for cloud-specific behavior.
  • black/isort/pylint (adds directory to pre-commit check)
  • remove some of the dead code, particularly in conftest files
  • uncovered an issue with path construction in _metadata for cloud-based parquet Dataset (the path is munged in the dataset construction, but not re-munged when we strip out the prefix for the file-level path).

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cdccc68) 99.69% compared to head (0f1806b) 99.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #176   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files          49       49           
  Lines        1652     1653    +1     
=======================================
+ Hits         1647     1648    +1     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 30, 2023

Before [cdccc68] After [84fe561] Ratio Benchmark (Parameter)
653±2ms 657±2ms 1.01 benchmarks.Suite.time_pixel_tree_creation
117±1ms 117±0.4ms 1 benchmarks.time_test_alignment_even_sky
95.4±0.6ms 95.3±0.3ms 1 benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu merged commit e5b8bf3 into main Dec 1, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants