Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Association table extra metadata #180

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Conversation

smcguire-cmu
Copy link
Contributor

Change Description

Updates Association table catalog info metadata to include extra fields to specify the joining columns names in the association table as separate names to the names in the original catalogs.

Updates required catalog_info fields now that we no longer use index joining with association tables.

Copy link

github-actions bot commented Dec 6, 2023

Before [5942afa] <v0.1.8> After [4c4f34e] Ratio Benchmark (Parameter)
645±4ms 648±2ms 1 benchmarks.Suite.time_pixel_tree_creation
98.5±0.2ms 98.8±0.8ms 1 benchmarks.time_test_cone_filter_multiple_order
117±0.6ms 116±0.8ms 0.99 benchmarks.time_test_alignment_even_sky

Click here to view all benchmarks.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5942afa) 99.70% compared to head (21498a4) 99.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #180   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files          51       51           
  Lines        1684     1688    +4     
=======================================
+ Hits         1679     1683    +4     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smcguire-cmu smcguire-cmu merged commit b4fa8fd into main Dec 7, 2023
10 checks passed
@smcguire-cmu smcguire-cmu deleted the sean/association-table-metadata branch December 7, 2023 22:23
@smcguire-cmu smcguire-cmu changed the title Sean/association table metadata Association table extra metadata Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants