Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused methods in pixel margin module #343

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Methods were unused by margin generation filtering code, either in import or LSDB packages.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.97%. Comparing base (efb34b6) to head (a9407cd).
Report is 79 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
- Coverage   94.05%   93.97%   -0.08%     
==========================================
  Files          58       58              
  Lines        2135     2124      -11     
==========================================
- Hits         2008     1996      -12     
- Misses        127      128       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Before [efb34b6] After [11a8b2c] Ratio Benchmark (Parameter)
372±3ms 383±8ms 1.03 benchmarks.Suite.time_outer_pixel_alignment
88.2±2ms 90.2±2ms 1.02 benchmarks.Suite.time_paths_creation
13.2±0.3ms 13.4±0.6ms 1.01 benchmarks.Suite.time_inner_pixel_alignment
41.8±0.9ms 42.2±1ms 1.01 benchmarks.Suite.time_pixel_tree_creation
20.0±0.5ms 19.9±0.2ms 1 benchmarks.MetadataSuite.time_load_partition_info_order6
77.6±0.6ms 76.5±0.2ms 0.99 benchmarks.MetadataSuite.time_load_partition_info_order7
77.3±0.5ms 76.9±0.7ms 0.99 benchmarks.MetadataSuite.time_load_partition_join_info
113±2ms 112±0.6ms 0.99 benchmarks.time_test_alignment_even_sky
996±20μs 961±2μs 0.96 benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu requested a review from hombit September 16, 2024 14:41
Copy link
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice catch

@delucchi-cmu delucchi-cmu merged commit 4357f0c into main Sep 16, 2024
11 of 12 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/margin branch September 16, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants