Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APE 22: Update Affiliated info #573

Merged
merged 5 commits into from
Mar 20, 2024
Merged

Conversation

pllim
Copy link
Member

@pllim pllim commented Feb 14, 2024

@pllim

This comment was marked as outdated.

affiliated/index.html Outdated Show resolved Hide resolved
affiliated/index.html Outdated Show resolved Hide resolved
affiliated/index.html Outdated Show resolved Hide resolved
@lwasser
Copy link
Contributor

lwasser commented Mar 6, 2024

This all looks really good @pllim . When i revisit our workflow some (which i've been doing) do you want me to explore adding a JSON file so we export both json and yaml as a future task that could make your life easier? if that as possible you could actually create a CI build that updated a file here like i did for pyopensci. the keys might be a bit different from what you have now is the only potential glitch.

@pllim
Copy link
Member Author

pllim commented Mar 6, 2024

Re: explore JSON vs YAML -- I think browser natively prefers JSON but yes, I will be happy to explore this, but not in this PR.

@pllim pllim force-pushed the so-open-much-affiliated branch from 0bcc9c7 to 1f5161d Compare March 6, 2024 20:22
Copy link
Member

@eteq eteq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a bunch of inline suggestions, but I am mostly happy, so approving becasue I think even without the suggestions its ok (although I would prefer they be accepted).

One other general comment though: @mwcraig, do you have any thoughts/concerns about removing mention of the astropy conda channel. I think it's unmaintained at this point, since everything's on conda-forge, right? But this removes what I think is the last mention of it so just want to confirm you are happy with this.

CONTRIBUTING.md Show resolved Hide resolved
about.html Outdated Show resolved Hide resolved
affiliated/index.html Outdated Show resolved Hide resolved
affiliated/index.html Outdated Show resolved Hide resolved
affiliated/index.html Outdated Show resolved Hide resolved
Copy link
Member

@ceb8 ceb8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Noticed one typo.

affiliated/index.html Outdated Show resolved Hide resolved
@mwcraig
Copy link
Member

mwcraig commented Mar 18, 2024

One other general comment though: @mwcraig, do you have any thoughts/concerns about removing mention of the astropy conda channel. I think it's unmaintained at this point, since everything's on conda-forge, right? But this removes what I think is the last mention of it so just want to confirm you are happy with this.

I am fine with this -- I haven't used that channel myself in years...

Co-authored-by: Erik Tollerud <[email protected]>
Co-authored-by: C. E. Brasseur <[email protected]>
@eteq eteq merged commit 2c844f3 into astropy:main Mar 20, 2024
1 check passed
@pllim
Copy link
Member Author

pllim commented Mar 20, 2024

It's been over a month and has multiple approvals, so I am merging this. Thanks, all!

(OK nvm, Erik merge it as I typed this. Thanks lol)

@pllim pllim deleted the so-open-much-affiliated branch March 20, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants