-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APE 22: Update Affiliated info #573
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
7465d57
to
124b0c7
Compare
This all looks really good @pllim . When i revisit our workflow some (which i've been doing) do you want me to explore adding a JSON file so we export both json and yaml as a future task that could make your life easier? if that as possible you could actually create a CI build that updated a file here like i did for pyopensci. the keys might be a bit different from what you have now is the only potential glitch. |
Re: explore JSON vs YAML -- I think browser natively prefers JSON but yes, I will be happy to explore this, but not in this PR. |
Co-authored-by: Leah Wasser <[email protected]>
Co-authored-by: Leah Wasser <[email protected]>
0bcc9c7
to
1f5161d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a bunch of inline suggestions, but I am mostly happy, so approving becasue I think even without the suggestions its ok (although I would prefer they be accepted).
One other general comment though: @mwcraig, do you have any thoughts/concerns about removing mention of the astropy conda channel. I think it's unmaintained at this point, since everything's on conda-forge, right? But this removes what I think is the last mention of it so just want to confirm you are happy with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Noticed one typo.
I am fine with this -- I haven't used that channel myself in years... |
Co-authored-by: Erik Tollerud <[email protected]> Co-authored-by: C. E. Brasseur <[email protected]>
It's been over a month and has multiple approvals, so I am merging this. Thanks, all! (OK nvm, Erik merge it as I typed this. Thanks lol) |
I realized that I really need to also update the webpages to go with astropy/astropy-project#372 . Otherwise, things get too confusing.
This is a follow-up of astropy/astropy-APEs#87
Preview landing page: https://output.circle-artifacts.com/output/job/3254fe85-dac2-4db3-8f0c-55dee820a26e/artifacts/0/html/index.html
cc @dhomeier @hamogu @astropy/coordinators @lwasser