Ignore RA/Dec string formatting failures #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mwcraig
approved these changes
Oct 19, 2020
|
For Windows failure, try 7720c63 |
mwcraig
force-pushed
the
ignore-radec-fmt-err-
branch
from
f137df4 to
7668028
Compare
|
I'll wait to see what works in #117 then rebase.... |
mwcraig
force-pushed
the
ignore-radec-fmt-err-
branch
from
7668028 to
68cefe0
Compare
|
Thanks! 😄 |
|
Doing a 0.2 release, so that means there won't be any 0.1.2, re-milestoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with #110, I found that invalid WCS causes the cursor info bar to not display at all, when the values raises
AssertionErrorin Ginga. I find that it makes more sense to display info bar anyway without RA and Dec, when WCS conversion fails for whatever reason, instead to just not work.