Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: cleanup unused build-time dependencies #201

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

neutrinoceros
Copy link
Contributor

Replaces #200

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (648c861) 78.83% compared to head (b6e5110) 78.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #201   +/-   ##
=======================================
  Coverage   78.83%   78.83%           
=======================================
  Files          10       10           
  Lines         992      992           
=======================================
  Hits          782      782           
  Misses        210      210           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

devdeps failure is unrelated and since synphot is involved, I probably should open a follow-up PR to fix that.

(The infrastructure not very clean in this repo.)

@pllim pllim merged commit aa4ceab into astropy:main Dec 5, 2023
8 of 9 checks passed
@neutrinoceros neutrinoceros deleted the cleanup_buildtime_dependencies branch December 5, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants