-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove an error at the end of the -h "help" flag #1632
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Hello, @changeset-bot[bot]! 👋🏼
|
Quality Gate passedIssues Measures |
Thank you for the PR : ) @neoandmatrix can you try to verify the changes via running in your local, to verify the changes and running local instructions are given in the contributions guideline of the CLI project |
Sure will verify and attach the screenshot of changes. |
After doing the mentioned changes in PR and upon running the commands Before changes :-
After changes :-
@AayushSaini101 Please verify. |
/rtm |
Related issue(s)
Resolves #1625
Description
This PR helps to fix the ERROR message issue in the -h help command flag.
Approach
Upon going through the codebase i first tried to log more of error message and got the following for stack trace of the error message.
With referring to above trace and going through the oclif codebase i found that the error being shown here is not an actual error but just used to terminate the help command.
This is that particular code.
Then after carefully going through help command implementation in the oclif codebase and also referring to an already mentioned old issue about this bug and their solution i concluded that this error is safe to ignore as this is expected in the command output and is not critical.
@AayushSaini101 Please review this PR.
Thanks.