Create user #2
Open
Create user #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinDelille
commented
Dec 20, 2018
.../src/main/java/org/xwiki/contrib/usersync/discourse/internal/DiscourseUserSyncConnector.java
Outdated
Show resolved
Hide resolved
MartinDelille
commented
Dec 21, 2018
.../src/main/java/org/xwiki/contrib/usersync/discourse/internal/DiscourseUserSyncConnector.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/xwiki/contrib/usersync/discourse/internal/DiscourseUserSyncConnector.java
Outdated
Show resolved
Hide resolved
MartinDelille
commented
Dec 23, 2018
tmortagne
reviewed
Dec 31, 2018
pom.xml
Outdated
| @@ -60,6 +64,13 @@ | |||
|
|
|||
| <!-- The repository where to get XWiki dependencies --> | |||
| <repositories> | |||
| <repository> | |||
There was a problem hiding this comment.
Il n'y as aucune raison pour que tu ai besoin de ça. Maven central est activé de base dans Maven.
tmortagne
reviewed
Dec 31, 2018
tmortagne
reviewed
Dec 31, 2018
| @@ -31,6 +31,7 @@ | |||
| @Role | |||
| public interface UserSyncConnector | |||
| { | |||
| void getUser(String userId); | |||
There was a problem hiding this comment.
Cette methode n'as pas de sens dans cette API. Si c'est juste pour ton test unitaire il te suffit de caster this.mocker.getComponentUnderTest() en DiscourseUserSyncConnector pour appeller la methode temporaire. Ça évitera d'oublier de la virer à la fin ;)
|
@tmortagne C'est bon cette première étape est terminée de mon côté. J'ai un problème indépendant mais je vais créer une issue spécifique. Je te laisse me faire un retour et merger si ça te parait bon! |
|
@tmortagne je viens de pousser ce qu'on a fait en début d'aprèm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.