This repository has been archived by the owner on Mar 27, 2022. It is now read-only.
topAuthor links #188
Closed
topAuthor links #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coder-do
commented
Feb 24, 2021
| @@ -1,6 +1,6 @@ | |||
| const topAutors = [ | |||
| { | |||
| 'Draft url': 'https://app.hackernoon.com/drafts/4E6A2NsOCdVtUSOvZ0rz', | |||
| 'Draft url': '', | |||
There was a problem hiding this comment.
@vadim9999 если эту пустую строку убрать по моему ничего не сломается я его создаю практически здесь - src/pages/TOPAuthors/TOPAuthors.tsx
coder-do
commented
Feb 24, 2021
| return { | ||
| key: item?.id, | ||
| ...item | ||
| ...item, | ||
| 'Draft url': topAuthorLinks[index] |
|
In top authors we reciving data from database. @atherdon help) |
|
@vadim9999 #116 здесь был таск чтоб вынести, ну если уже эти данные идут из бд - то мне уже нечего вынести тогда ))) |
|
cc @vadim9999 |
|
@coder-do да, нужно закрыть PR потому что мы уже тянем данные с бека |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@atherdon вынес эти ссылки тоже - если такой вариант будет нормально , можно таким способом вынести и другие ссылки