Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-4380 fix: ensure DOCKERFILE installs the current version of argopm #97

Merged
merged 3 commits into from
Dec 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/npm-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,14 @@ jobs:
- uses: actions/[email protected]
with:
fetch-depth: 0
- name: Get published version
id: get_version
run: |
ARGOPM_VERSION=$(npm show . version)
echo "The published version is: $ARGOPM_VERSION"
echo "::set-output name=argopm_version::$ARGOPM_VERSION"
# sleep 5 sec to make sure we can install the latest published version from npm in Dockerfile
sleep 5
- name: 'Get Previous tag'
id: previoustag
uses: "WyriHaximus/github-action-get-previous-tag@master"
Expand Down Expand Up @@ -56,3 +64,4 @@ jobs:
build-args: |
ACCESS_TOKEN_USR=$GITHUB_ACTOR
ACCESS_TOKEN_PWD=${{ secrets.ORG_PAT_GITHUB }}
ARGOPM_VERSION=${{ steps.get_version.outputs.published_version }}
4 changes: 3 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
FROM node:20-alpine

ARG ARGOPM_VERSION

RUN mkdir /app

WORKDIR /app

COPY . /app

RUN npm install argopm -g
RUN npm install argopm@${ARGOPM_VERSION} -g

RUN npm install

Expand Down
Loading