Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FT-653: Provide helper to create OpenLineage connection #479

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

FT-653: Provide helper to create OpenLineage connection #479

wants to merge 11 commits into from

Conversation

vaibhavatlan
Copy link
Collaborator

No description provided.

Aryamanz29
Aryamanz29 requested changes Jan 16, 2025
View reviewed changes
Copy link
Member

@Aryamanz29 Aryamanz29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress!
Here are a few minor suggestions for improvement:

pyatlan/client/open_lineage.py Outdated Show resolved Hide resolved
pyatlan/client/open_lineage.py Outdated Show resolved Hide resolved
pyatlan/client/open_lineage.py Outdated Show resolved Hide resolved
pyatlan/client/open_lineage.py Show resolved Hide resolved
tests/integration/test_open_lineage.py Outdated Show resolved Hide resolved
tests/integration/test_open_lineage.py Outdated Show resolved Hide resolved
tests/integration/test_open_lineage.py Show resolved Hide resolved
tests/integration/test_open_lineage.py Outdated Show resolved Hide resolved
tests/integration/test_open_lineage.py Outdated Show resolved Hide resolved
tests/integration/test_open_lineage.py Outdated Show resolved Hide resolved
@vaibhavatlan vaibhavatlan self-assigned this Jan 17, 2025
@vaibhavatlan vaibhavatlan added the feature New feature or request label Jan 17, 2025
Aryamanz29
Aryamanz29 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@Aryamanz29 Aryamanz29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
I enhanced the test assertions by incorporating audit search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aryamanz29 Aryamanz29 Aryamanz29 approved these changes

Assignees

@vaibhavatlan vaibhavatlan

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vaibhavatlan @Aryamanz29