Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLH-36 | Integrating OTEL with logback #3933

Merged
merged 26 commits into from
Jan 29, 2025
Merged

MLH-36 | Integrating OTEL with logback #3933

merged 26 commits into from
Jan 29, 2025

Conversation

aarshi0301
Copy link

@aarshi0301 aarshi0301 commented Jan 3, 2025

Change description

Description here

  • contains log4j to logback conversion
  • contains OTEL integration with atlas-metsatore
  • contains filters for easy debugging
  • filter simulates index of ES in older logging flow
  • validated on local, beta and staging
  • JIRA : https://atlanhq.atlassian.net/browse/MLH-36

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@aarshi0301 aarshi0301 changed the title Otel3 Integrating OTEL with logback Jan 3, 2025
@aarshi0301 aarshi0301 changed the title Integrating OTEL with logback MLH-36| Integrating OTEL with logback Jan 22, 2025
@aarshi0301 aarshi0301 self-assigned this Jan 22, 2025
sumandas0
sumandas0 previously approved these changes Jan 22, 2025
@aarshi0301 aarshi0301 changed the title MLH-36| Integrating OTEL with logback MLH-36 | Integrating OTEL with logback Jan 22, 2025
Copy link

@nikhilbonte21 nikhilbonte21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing few upstream changes
distro/src/main/assemblies/notification-analyzer.xml
tools/notification-analyzer/pom.xml
a few lines in the root pom.xml

nikhilbonte21
nikhilbonte21 previously approved these changes Jan 28, 2025
Copy link

@nikhilbonte21 nikhilbonte21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared a minor comment, other than than LGTM

sumandas0
sumandas0 previously approved these changes Jan 28, 2025
@aarshi0301 aarshi0301 dismissed stale reviews from sumandas0 and nikhilbonte21 via 1f04397 January 28, 2025 14:44
@aarshi0301 aarshi0301 merged commit 07e55d7 into master Jan 29, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants