Add moduleId param to options that allow customization of virtualModuleId
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stryaponoff I missed this PR, do you want to fix conflicts so I can push it forward? |
# Conflicts: # README.md # src/index.ts
atlowChemi
reviewed
Feb 22, 2024
| const DEFAULT_MODULE_ID = 'vite-svg-2-webfont.css'; | ||
|
|
||
| function getVirtualModuleId<T extends string>(moduleId: T): `virtual:${T}` { | ||
| return `virtual:${moduleId}`; |
There was a problem hiding this comment.
Perhaps the virtual prefix should also be a const?
WDYT?
There was a problem hiding this comment.
I can do it if you want, but I personally don't think it's necessary because it's just a simple conventional value that never implies to be changed and it is not used anywhere else.
atlowChemi
approved these changes
Feb 22, 2024
atlowChemi
changed the title
moduleId param to options that allow customization of virtualModuleId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My project needs multiple fonts to be generated so I solve it with multiple instances of this plugin with different moduleId.