Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiment: Use fillText #754

Closed
wants to merge 1 commit into from
Closed

Experiment: Use fillText #754

wants to merge 1 commit into from

Conversation

aminya
Copy link
Collaborator

@aminya aminya commented Jan 7, 2021 •
edited
Loading

This uses fillText instead of fillRect to render the exact text.

  • The performance should be evaluated.
  • minimap-titles should be updated (its rendering now looks a little different).

image

@aminya aminya force-pushed the fillText branch 3 times, most recently from 1f4b9f1 to e2649f2 Compare January 12, 2021 06:06
@aminya
Copy link
Collaborator Author

aminya commented Jan 12, 2021

This seems slower:
image

@UziTech
Copy link
Collaborator

UziTech commented May 22, 2021

Closing since it is marked wontfix

@UziTech UziTech closed this May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
performance wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aminya @UziTech