-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mip map example #86
base: master
Are you sure you want to change the base?
Conversation
It looks like this PR eliminates most of the remaining validation errors in my renderer! There's one relevant case where it might not be using the correct barrier. I have a set of passes like this: let mut mip = 0;
while width > 1 && height > 1 {
graph
.begin_pass("low_z_prepass_pyramid")
.bind_pipeline([...])
.read_descriptor_as(0, depth_node, info_mip(dwrite_info, mip))
.write_descriptor_as(1, depth_node, info_mip(dwrite_info, mip + 1))
.record_compute(move |compute, _bindings| {
compute.dispatch(width / 8 + 1, height / 8 + 1, 1);
});
width /= 2;
height /= 2;
mip += 1;
}
fn info_mip(info: ImageViewInfo, level: u32) -> ImageViewInfo {
let mut write_info = info;
write_info.base_mip_level = level;
write_info.mip_level_count = Some(1);
write_info
} And it seems that the
|
I did just notice that with this PR I'm getting undefined img in render doc on some attachments and it just renders black on a GTX1060. Still need to track down the cause or make a minimal reproduction. Just wanted to mention. (I tried a few of the basic examples in this repo and it didn't occur, though there were other vulkan validation errors) |
No description provided.