Fix fuzzer find and clean up a bit

Makefile

@@ -52,4 +52,4 @@ analyze:
 	clang++ --analyze $(CXXFLAGS) lib/*.cpp utils/*.cpp
 
 fuzz:
-	clang++ -g -O1 -fsanitize=fuzzer $(CXXFLAGS) -O1 lib/ippmsg.cpp lib/ippattr.cpp bytestream/bytestream.cpp -o $@
+	clang++ -g -O1 -fsanitize=fuzzer $(CXXFLAGS) -O1 -DFUZZ lib/ippmsg.cpp lib/ippattr.cpp bytestream/bytestream.cpp -o $@

lib/ippattr.cpp

@@ -82,11 +82,11 @@ std::ostream& operator<<(std::ostream& os, const IppValue& iv)
     os << "{";
     IppCollection ippCollection = iv.get<IppCollection>();
     IppCollection::const_iterator it = ippCollection.cbegin();
-    os << "\"" << it->first << "\": " << it->second;
+    os << "\"" << it->first << "\": " << it->second.value();
     it++;
     for(; it != ippCollection.cend(); it++)
     {
-      os << ", \"" << it->first << "\": " << it->second;
+      os << ", \"" << it->first << "\": " << it->second.value();
     }
     os << "}";
   }

lib/ippmsg.cpp

@@ -30,8 +30,10 @@ IppMsg::IppMsg(Bytestream& bts)
       }
       else if (currentAttrType == UnsupportedAttrs)
       {
+#ifndef FUZZ // Too much spam for fuzzing
         std::cerr << "WARNING: unsupported attrs reported: " << std::endl
                   << attrs;
+#endif
       }
 
       if(bts >>= EndAttrs)
@@ -278,7 +280,7 @@ IppValue IppMsg::collectAttributes(List<IppAttr>& attrs) const
     }
     else
     {
-      std::cerr << "out of sync with collection" << tmpval.tag();
+      throw std::logic_error("out of sync with collection");
     }
   }
 

lib/list.h

@@ -2,6 +2,7 @@
 #define LIST_H
 
 #include <list>
+#include <stdexcept>
 
 template <typename T>
 class List: public std::list<T>
@@ -11,7 +12,12 @@ class List: public std::list<T>
 
   T takeFront()
   {
-    T tmp = std::list<T>::front();
+    if(std::list<T>::empty())
+    {
+      throw std::logic_error("List is empty");
+    }
+
+    T tmp(std::list<T>::front());
     std::list<T>::pop_front();
     return tmp;
   }