Add dynamic size for AggregationBits

attestantio · Jan 10, 2025 · 0da473e · 0da473e
1 parent 79a5ffa
commit 0da473e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/spec/electra/attestation.go b/spec/electra/attestation.go
@@ -28,9 +28,11 @@ import (
 )
 
 // Attestation is the Ethereum 2 attestation structure.
+//
+//nolint:tagalign
 type Attestation struct {
 	// bitfield.Bitlist has size of n bits + 1 length bit, e.g. an 8 bit list will require a 2 byte array.
-	AggregationBits bitfield.Bitlist `ssz-max:"16385"`
+	AggregationBits bitfield.Bitlist `ssz-max:"16385" dynssz-size:"((MAX_VALIDATORS_PER_COMMITTEE*MAX_COMMITTEES_PER_SLOT)/8 + 1)"`
 	Data            *phase0.AttestationData
 	Signature       phase0.BLSSignature `ssz-size:"96"`
 	// bitfield.Bitvector64 is an 8 byte array so dynamic sizing doesn't make sense.

diff --git a/spec/electra/attestation_ssz.go b/spec/electra/attestation_ssz.go
diff --git a/spec/electra/attestation_test.go b/spec/electra/attestation_test.go
@@ -163,6 +163,7 @@ func TestAttestation_SSZ(t *testing.T) {
 
 	// Should only have the bit that was set on the last bit.
 	require.Equal(t, 1, len(aggregateBits.BitIndices()))
+	require.Equal(t, aggregateSize, aggregateBits.Len())
 
 	// Set a bit beyond the bit vector.
 	committeeBits.SetBitAt(committeeSize, true)