Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signature utility functions #183

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Add signature utility functions #183

merged 1 commit into from
Jan 22, 2025

Conversation

Bez625
Copy link
Collaborator

@Bez625 Bez625 commented Jan 21, 2025

Utility methods requested in this comment #182 (comment)

@Bez625 Bez625 marked this pull request as ready for review January 21, 2025 21:06
@Bez625 Bez625 requested a review from mcdee January 21, 2025 21:06
@KaloyanTanev
Copy link

Much appreciated!

@KaloyanTanev
Copy link

KaloyanTanev commented Jan 22, 2025

@Bez625 do you think adding AggregatorIndex() as well makes sense?
And also adding SelectionProof() to the Versioned counterpart?

@Bez625 Bez625 merged commit be3c6bc into electra Jan 22, 2025
3 checks passed
@Bez625 Bez625 deleted the add_utility branch January 22, 2025 08:40
@Bez625
Copy link
Collaborator Author

Bez625 commented Jan 22, 2025

@Bez625 do you think adding AggregatorIndex() as well makes sense? And also adding SelectionProof() to the Versioned counterpart?

It's definitely possible to add those, but I can't see anywhere we would use them at the minute. Are they functions you would find useful? If so I'm happy to raise the change

@KaloyanTanev
Copy link

Yes, we have a couple of places throughout our Charon codebase where those will be quite handy. One example is here. I am currently refactoring the code to encompass the SubmitAggregateAttestationsOpts (and subsequently VersionedSignedAggregateAndProof) and being able to call directly agg.AggregatorIndex() as we've been doing previously with agg.Message.AggregatorIndex would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants