no need for fake values, set values in the test

auraphp · Nov 7, 2014 · 357ab37 · 357ab37
1 parent d7bfcf3
commit 357ab37
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/config/Common.php b/config/Common.php
@@ -39,24 +39,20 @@ public function define(Container $di)
          */
         $di->params['Aura\Auth\Adapter\HtpasswdAdapter'] = array(
             'verifier' => $di->lazyNew('Aura\Auth\Verifier\HtpasswdVerifier'),
-            'file' => 'NO_FILE_SPECIFIED',
         );
 
         /**
          * Aura\Auth\Adapter\ImapAdapter
          */
         $di->params['Aura\Auth\Adapter\ImapAdapter'] = array(
             'phpfunc' => $di->lazyNew('Aura\Auth\Phpfunc'),
-            'mailbox' => 'NO_MAILBOX_SPECIFIED',
         );
 
         /**
          * Aura\Auth\Adapter\LdapAdapter
          */
         $di->params['Aura\Auth\Adapter\LdapAdapter'] = array(
             'phpfunc' => $di->lazyNew('Aura\Auth\Phpfunc'),
-            'server' => 'NO_SERVER_SPECIFIED',
-            'dnformat' => 'NO_DNFORMAT_SPECIFIED',
         );
 
         /**

diff --git a/tests/container/src/CommonTest.php b/tests/container/src/CommonTest.php
@@ -32,10 +32,20 @@ public function provideGet()
     public function provideNewInstance()
     {
         return array(
-            array('Aura\Auth\Adapter\HtpasswdAdapter'),
-            array('Aura\Auth\Adapter\ImapAdapter'),
-            array('Aura\Auth\Adapter\LdapAdapter'),
-            array('Aura\Auth\Adapter\PdoAdapter', array('pdo' => new FakePDO)),
+            array('Aura\Auth\Adapter\HtpasswdAdapter', array(
+                'file' => 'fake-file',
+            )),
+            array('Aura\Auth\Adapter\ImapAdapter', array(
+                'mailbox' => 'fake-mailbox',
+            )),
+            array('Aura\Auth\Adapter\LdapAdapter', array(
+                'server' => 'fake-server',
+                'dnformat' => 'fake-dnformat',
+            )),
+            array('Aura\Auth\Adapter\PdoAdapter', array(
+                'pdo' => new FakePDO,
+                'verifier' => new \Aura\Auth\Verifier\PasswordVerifier('md5'),
+            )),
             array('Aura\Auth\Auth'),
             array('Aura\Auth\Service\LoginService'),
             array('Aura\Auth\Service\LogoutService'),