Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support never_on_login as allowed value for set_user_root_attributes #1123

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

duedares-rvj
Copy link
Contributor

@duedares-rvj duedares-rvj commented Jan 16, 2025

Added support for set_user_root_attributes to be set as never_on_login

🔧 Changes

📚 References

Closes #1121

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@duedares-rvj duedares-rvj requested a review from a team as a code owner January 16, 2025 07:13
@duedares-rvj duedares-rvj self-assigned this Jan 16, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (6387564) to head (1270357).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1123      +/-   ##
==========================================
- Coverage   89.29%   89.21%   -0.09%     
==========================================
  Files         130      130              
  Lines       18027    18054      +27     
==========================================
+ Hits        16097    16106       +9     
- Misses       1363     1379      +16     
- Partials      567      569       +2     

see 1 file with indirect coverage changes

Copy link
Contributor

@developerkunal developerkunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duedares-rvj duedares-rvj merged commit 8fb28bd into main Jan 16, 2025
5 checks passed
@duedares-rvj duedares-rvj deleted the DXCDT-816/never_on_login branch January 16, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auth0_connection doesn't support never_on_login for the set_user_root_attributes option
3 participants