Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth2 supported HttpClient in core module #193

Open
santhoshTpixler opened this issue Jan 19, 2019 · 4 comments
Open

OAuth2 supported HttpClient in core module #193

santhoshTpixler opened this issue Jan 19, 2019 · 4 comments
Labels
feature-request New feature which can be introduced

Comments

@santhoshTpixler
Copy link
Collaborator

santhoshTpixler commented Jan 19, 2019

Background:

We have an OAuth2 in action #186 in the authorjapps/zerocode-hello-world#7 repo. But it can be made as part of the core module. Since the OAuth2 implementation was generic enough to support most of the providers it will benefit many people.

AC1:

Follow this as reference or suggestion only(but check the latest IETF doc for standard impl):
#676 (review)

  • Internet Engineering Task Force (IETF) standard

AC2:

  • Log (WARN level) the access_token details or log the response
  • Log (WARN level) client_id and client_secret by masking it (e.g. for "secret123", log "s***3"or "***" to avoid extra logic)

and

  • Log (INFO level) client_id and client_secret as it is(without any masking)
@santhoshTpixler santhoshTpixler added the feature-request New feature which can be introduced label Jan 19, 2019
@agbanagba
Copy link

Hi @santhoshTpixler . What needs to be done to get this working. I will like to contribute.

@santhoshTpixler
Copy link
Collaborator Author

@agbanagba You are welcomed to contribute. 👍
As mentioned above in the issue, we have the Oauth2 supported HTTP client in the example repo. It has to move into the core project.
I am not sure the example implementation is the standard one.

@agbanagba
Copy link

Thats cool. I will be working on it. Thanks

@prayascoriolis
Copy link
Contributor

prayascoriolis commented Aug 29, 2024

@santhoshTpixler

I have reviewed both the core repository of Zerocode and its example repository (zerocode-hello-world) and have developed a good understanding of how they work. I found the implementation of OAuth2 in the example repository particularly interesting and would like to work on implementing it in the core repository. Could you please assign this issue to me?

I also have a few questions:

  • After implementing OAuth2 in the core repository, will users still need to specify a custom HTTP client in the unit runner Java class?

Tasks Required To Be Undertaken in Core Repo:

  1. Created a unit runner class with OAuth2 specifications.
  2. Added Java, properties, and JSON files for the custom HTTP client.
  3. Made minor path adjustments in the Java files and successfully ran the test class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature which can be introduced
Projects
None yet
Development

No branches or pull requests

3 participants