Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #193] Integrate OAuth2 Authentication into Core Repository #676

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

prayascoriolis
Copy link
Contributor

@prayascoriolis prayascoriolis commented Aug 30, 2024

[Issue #193] Implement OAuth2 Authentication in Core Repository

Fixes Issue: 193

PR Branch
https://github.com/prayascoriolis/zerocode/tree/ISSUE-193-OAuth2-Support

Motivation and Context

The integration of OAuth2 authentication into the core repository is a key enhancement that will make the library more versatile and secure. By aligning this effort with the successful example from the zerocode-hello-world repository, you are paving the way for a robust authentication mechanism that can be leveraged across various use cases.

PR Description:

This pull request integrates OAuth2 authentication into the core repository. The following tasks have been undertaken:

  1. Created a unit runner class with OAuth2 specification.
  2. Included necessary Java, properties, and JSON files for the custom HTTP client.
  3. Made minor path adjustments in the Java files to ensure successful test execution.

Checklist:

  • New Unit tests were added

  • Integration tests were added

  • Test names are meaningful

  • Feature manually tested and outcome is successful

  • PR doesn't break any of the earlier features for end users

  • Branch build passed in CI

  • No 'package.*' in the imports

  • Http test added to http-testing module(if applicable)

  • Not applicable. The changes did not affect Kafka automation flow

@prayascoriolis prayascoriolis changed the title WIP: [ISSUE #193] Integrate OAuth2 Authentication into Core Repository WIP: [Issue #193] Integrate OAuth2 Authentication into Core Repository Aug 30, 2024
@authorjapps
Copy link
Owner

@prayascoriolis , can you rebase or merge "master" to this PR branch please?

@prayascoriolis
Copy link
Contributor Author

@authorjapps i've merged branch "master" to this PR branch.

@authorjapps
Copy link
Owner

@authorjapps i've merged branch "master" to this PR branch.

ok. Thank you. Let me check if the build gets through(earlier it was stuck due to the Ubuntu image issue from GitHub Actions)

@authorjapps
Copy link
Owner

@prayascoriolis
Copy link
Contributor Author

You can check here as well @prayascoriolis : https://github.com/authorjapps/zerocode/pull/676/checks

Thankyou, @authorjapps, All the checks have passed.

Copy link
Collaborator

@nirmalchandra nirmalchandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prayascoriolis , thanks for trying to impl this.
Here are some observations and suggestions:

@prayascoriolis
Copy link
Contributor Author

@authorjapps @nirmalchandra I've completed the end to end implementation of oauth2 access token alog with refresh_token, can you please review it ?

@prayascoriolis prayascoriolis changed the title WIP: [Issue #193] Integrate OAuth2 Authentication into Core Repository [Issue #193] Integrate OAuth2 Authentication into Core Repository Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants