-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE-58 #Codecov configuration to check code coverage #119
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
=========================================
Coverage ? 69.24%
=========================================
Files ? 91
Lines ? 2279
Branches ? 213
=========================================
Hits ? 1578
Misses ? 620
Partials ? 81 Continue to review full report at Codecov.
|
#ignore tag- all files which are not "meant" to be unit-tested, like GUI and constants-files | ||
# so coverage percent won't be reduce by this code. | ||
ignore: | ||
- "zerocode/src/main/java/org/jsmart/zerocode/converter/SoapMocker.java" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
More classes like this to be added ie task on me.
|
||
Code Coverage Report | ||
-------------------- | ||
Link to see the coverage : http://please-provide-the-link-here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls provide link for live coverage report please. That's the purpose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link is not generic one. Once you merge this PR, we need to update this link as per zerocde code coverage report.
e.g. link could be similar to - https://codecov.io/gh/aghorpade/zerocode
@@ -231,6 +231,21 @@ | |||
<target>${java-compiler-target.version}</target> | |||
</configuration> | |||
</plugin> | |||
|
|||
<!-- code cov plugin to generate report on code coverage--> | |||
<plugin> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just check, do we need the cobertura
plugin for local profile? If not, then keep only for release
profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to check code coverage on local machine,we will need it in local profile. If there is no need then we can remove it
ignore section not getting recognized for coverage. probably path is wrong for java files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parking this to prevent accidental merging.
To add code coverage -
How do we integrate it with GitHub?
Sign up in codecov.io via your GitHub account, give access to repository on which report has to be generated.
Once pull request is merged, code coverage will be generated on codecov.io website then you can add that report link in README.md