Rkuris/golang ffi #763
Merged
Rkuris/golang ffi #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has to be checked in for others to build this module
Also added a method to get the current root hash
Avoid making a copy of the go object Value Also cleaned up docs
These allow you to specify a few parameters as well, and could use a builder.
Also add fwd_close_db
Still to-do is to change the FFI call to take the double byte slice array instead of the KeyValue struct for performance reasons.
A test failure stems from the original delete implementation
This trims the database at the provided prefix
Added test
Same test as in the ffi done again here, which is easier to debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #762