Improve fwdctl dump #764
Open
Improve fwdctl dump #764
+585
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkuris
requested changes
Dec 26, 2024
There was a problem hiding this comment.
This looks really good! A few things we need before landing:
- Error handling when writing is very important here. We can't drop IO errors, or we risk having a bad dump with no warning
- Continuation has to support hash key values, not just text. If the next key is binary, the lossy UTF-8 inputs won't work correctly. Maybe we need
start-key-hex? - Small bug in the stop key
Otherwise, this looks fantastic! Great test coverage!
The remaining comments are mostly style preferences and are not mandatory.
fwdctl/src/dump.rs
Outdated
|
|
||
| trait OutputHandler { | ||
| fn handle_record(&mut self, key: &[u8], value: &[u8]); | ||
| fn flush(&mut self); |
There was a problem hiding this comment.
I debated implementing flush as a Drop for those implementations that require it, but that limits your error handling to panic.
Thanks for reviewing the code! I pushed some commits to improve. It should be ready to be reviewed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This change is to address issue #348.
Detail
This added flags such as
--start-key,--stop-key,--max-key-countand--output-formatwithcsv,jsonas options andstdoutas default behavior.Test
Tested locally & unit tests added