-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core/types): Block
RLP + Body hooks
#105
base: qdm12/core/types/body-hooks-rlp
Are you sure you want to change the base?
feat(core/types): Block
RLP + Body hooks
#105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately I think we may need to patch up Body as well, since this type is used in core/rawdb
in Read/WriteBody, which we intend to use upstream code for.
The added fields are the same, so I am not sure if there is a clever way to handle them both with one registration, but having overall 3 types we patch in like this:
- Header
- Body
- Block
seems fine to me too.
core/types/block.go
Outdated
@@ -309,11 +311,14 @@ func CopyHeader(h *Header) *Header { | |||
cpy.ParentBeaconRoot = new(common.Hash) | |||
*cpy.ParentBeaconRoot = *h.ParentBeaconRoot | |||
} | |||
if h.extra != nil { | |||
cpy.extra = h.extra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this copy should be a deep copy so likely adding a method to header hooks is needed.
EDIT: you're right, never mind! Working on it! Doesn't https://github.com/ava-labs/coreth/pull/750/files#diff-e177ddb5610d1f3426c15cb512999613785b20838954e48187883e6263bb282bR45 suffice? 🤔 Or at least for now, we can then do a PR for the body after to keep things tidy and one-step-at-a-time? |
f3bb9ed
to
dc9e4f8
Compare
We can merge 1 PR at a time to libevm, but I'd like to close the loop on the whole point of this exercise which is to be able to drop the We can make the next PR to this branch if you think it's cleaner that way, so we can continue verifying the integration with coreth/subnet-evm contains everything we need before fully fleshing out tests & solidifying the changes. |
5ea4a39
to
463996d
Compare
Block
RLP codec hooks
463996d
to
abbba71
Compare
e7193b7
to
7f6afca
Compare
Block
RLP codec hooksBlock
RLP + Body hooks
818f7ab
to
11c780f
Compare
Why this should be merged
How this works
How this was tested
Block
libevm Body and RLP hooks coreth#750