-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I removed the date command #17
base: master
Are you sure you want to change the base?
Conversation
Can you merge your changes with the latest code please, and fix the cut? I'd love to merge this :-) |
Actually, with the new architecture, everything but the date stuff is fixed already. The current version should only have the date bits changed (and I think this'll work on older versions of bash). |
…t works for older bash
Several things:
|
Have you tested printf with bash 3.2? I just don't want to issue another request that won't work for avleen. And Re: the stat change, I'll agree it's inefficient (although not majorly so; it takes less than half a second to size-check a 700K text file) but not for that reason; we have to read the entire file into memory anyway since we're serving it up. |
What's wrong with using stat? I'd much rather use something that's O(1) rather than O(n) to calculate length. (Note that I also tested using bash's built-in strlen with |
Nothing is wrong with stat, but it's not built into bash (or guaranteed to exist at all, in fact). |
No description provided.