Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic tone mapping #996

Merged
merged 10 commits into from
Nov 30, 2024
Merged

Automatic tone mapping #996

merged 10 commits into from
Nov 30, 2024

Conversation

awawa-dev
Copy link
Owner

@awawa-dev awawa-dev commented Nov 25, 2024

It implements my idea resulting from the observation that the captured raw HDR material is quite dark, thanks to which we can recognize it if it does not exceed a certain set brightness level for a certain time. However, exceeding it will be an immediate unambiguous signal that we are dealing with an SDR source.

Implements #749

@awawa-dev awawa-dev marked this pull request as ready for review November 28, 2024 13:24
@awawa-dev
Copy link
Owner Author

awawa-dev commented Nov 29, 2024

Hi @AstaRom
As always thanks for the PR that includes the translation of this new feature (#998) 👍 Based on further testing I will add some changes to the description details regarding auto calibration later.

Did you have a chance to test it? I noticed a funny thing that ms2130 reports limited range and max brightness around ~150 (Y) during the calibration, but later after returning to Windows the range is full and max brightness is around 170 (Y). That's why I rise the default Y-threshold to 180, but I'm not sure because it's just Windows and not a video player. 180 may cause less sensitive detection while playing the movies and 160 could be preferable as a default.

BTW when some threshold (Y, U or V) is exceeded, which turns off tone mapping since theoretically we have SDR signal, its value is reported in HyperHDR logs so it can be read and corrected in the config later.

@AstaRom
Copy link
Contributor

AstaRom commented Nov 29, 2024

Good afternoon.
I would like to try out new features, but unfortunately I won’t be able to do this in the near future (I have started a global renovation of the house, the entire installation has been disassembled, and the TV itself is now packed in the box 😀).

@awawa-dev
Copy link
Owner Author

I understand :) Good luck with your project!

@awawa-dev awawa-dev force-pushed the automatic_tone_mapping branch from c4bf9d9 to 8b8455e Compare November 30, 2024 15:40
@awawa-dev awawa-dev merged commit 00b0611 into master Nov 30, 2024
15 checks passed
@awawa-dev awawa-dev deleted the automatic_tone_mapping branch November 30, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic HDR (and Dolby Vision: LLDV) / SDR signal detection and tone mapping control for HyperHDR
2 participants