fixed some buttons using the <a> element on Plannable Deskop Apps

awesome-schedule · Mar 6, 2021 · 2c11772 · 2c11772
1 parent 5777b09
commit 2c11772
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/src/components/Pagination.vue b/src/components/Pagination.vue
@@ -14,7 +14,9 @@
                 />
             </li>
             <li class="page-item" :class="{ disabled: start <= 0 && idx <= start }">
-                <a class="page-link" href="#" @click="switchPage(idx - 1)">&laquo;</a>
+                <a class="page-link" href="javascript:void(0);" @click="switchPage(idx - 1)"
+                    >&laquo;</a
+                >
             </li>
             <!-- Note: v-for in number gives 1 to number inclusive -->
             <li
@@ -23,12 +25,18 @@
                 class="page-item"
                 :class="{ active: idx === index + start - 1 }"
             >
-                <a class="page-link" href="#" @click="switchPage(index + start - 1)">
+                <a
+                    class="page-link"
+                    href="javascript:void(0);"
+                    @click="switchPage(index + start - 1)"
+                >
                     {{ index + start }}
                 </a>
             </li>
             <li class="page-item" :class="{ disabled: idx >= scheduleLength - 1 }">
-                <a class="page-link" href="#" @click="switchPage(idx + 1)">&raquo;</a>
+                <a class="page-link" href="javascript:void(0);" @click="switchPage(idx + 1)"
+                    >&raquo;</a
+                >
             </li>
         </ul>
     </nav>

diff --git a/src/components/tabs/ExportView.vue b/src/components/tabs/ExportView.vue
@@ -159,7 +159,7 @@
                                         :class="{
                                             active: ver.version === prof.currentVersion
                                         }"
-                                        href="#"
+                                        href="javascript:void(0);"
                                         :title="`Full user agent: ${ver.userAgent}`"
                                         @click.stop="switchVersion(prof.name, idx, ver.version)"
                                     >

diff --git a/src/components/tabs/Information.vue b/src/components/tabs/Information.vue
@@ -87,7 +87,7 @@
                         >
                         <a class="nav-link ml-3 my-1 py-1" href="#item-11-3">Source of Data</a>
                     </nav>
-                    <a href="" class="mt-5"></a>
+                    <a href="javascript:void(0);" class="mt-5"></a>
                 </div>
             </nav>
         </nav>
-Original file line number
+Diff line change
@@ Expand Up / @@ -87,7 +87,7 @@ @@
                             >
                             <a class="nav-link ml-3 my-1 py-1" href="#item-11-3">Source of Data</a>
                         </nav>
-                        <a href="" class="mt-5"></a>
+                        <a href="javascript:void(0);" class="mt-5"></a>
                     </div>
                 </nav>
             </nav>
@@ Expand Down @@