Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): ignore user cancel when session is expired on hostedui sign out #3956

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Jan 31, 2025

#3943

Issue #

Description

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 requested a review from a team as a code owner January 31, 2025 18:56
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 68.96552% with 27 lines in your changes missing coverage. Please review.

Project coverage is 67.76%. Comparing base (67d40be) to head (d1b9685).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ions/Helpers/FetchAuthSessionOperationHelper.swift 56.09% 18 Missing ⚠️
...toAuthPlugin/Actions/SignOut/InitiateSignOut.swift 75.86% 7 Missing ⚠️
...thPlugin/Actions/SignOut/ShowHostedUISignOut.swift 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3956      +/-   ##
==========================================
- Coverage   67.79%   67.76%   -0.03%     
==========================================
  Files        1125     1125              
  Lines       52126    52204      +78     
==========================================
+ Hits        35337    35377      +40     
- Misses      16789    16827      +38     
Flag Coverage Δ
API_plugin_unit_test 70.37% <ø> (+0.04%) ⬆️
AWSPluginsCore 70.36% <ø> (ø)
Amplify 47.89% <ø> (ø)
Analytics_plugin_unit_test 85.20% <ø> (ø)
Auth_plugin_unit_test 73.71% <68.96%> (-0.03%) ⬇️
DataStore_plugin_unit_test 83.29% <ø> (-0.18%) ⬇️
Geo_plugin_unit_test 74.86% <ø> (ø)
Logging_plugin_unit_test 63.11% <ø> (ø)
Predictions_plugin_unit_test 35.42% <ø> (ø)
PushNotifications_plugin_unit_test 88.43% <ø> (ø)
Storage_plugin_unit_test 76.88% <ø> (ø)
unit_tests 67.76% <68.96%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thisisabhash
Copy link
Member

thisisabhash commented Feb 5, 2025

Can you add a detailed description of the changes for future reference?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants