Merge pull request #121 from aws-samples/fix/dependency-on-copy-samples

Fix/dependency on copy samples
aws-samples · Jul 5, 2022 · 3f50f2f · 3f50f2f
2 parents 07f3cd9 + 9b5bdd0
commit 3f50f2f
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.2.5] - 2022-07-05
+### Fixed
+- Stack failure when 'loadSampleAudioFiles` set to `false` 
+
 ## [0.2.4] - 2022-06-10
 ### Fixed
 - Use sigv4 for S3 presignedURLS
@@ -54,7 +58,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
 - Initial release
 
-[Unreleased]: https://github.com/aws-samples/amazon-transcribe-post-call-analytics/compare/v0.2.4...develop
+[Unreleased]: https://github.com/aws-samples/amazon-transcribe-post-call-analytics/compare/v0.2.5...develop
+[0.2.5]: https://github.com/aws-samples/amazon-transcribe-post-call-analytics/releases/tag/v0.2.5
 [0.2.4]: https://github.com/aws-samples/amazon-transcribe-post-call-analytics/releases/tag/v0.2.4
 [0.2.3]: https://github.com/aws-samples/amazon-transcribe-post-call-analytics/releases/tag/v0.2.3
 [0.2.2]: https://github.com/aws-samples/amazon-transcribe-post-call-analytics/releases/tag/v0.2.2

diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-0.2.4
+0.2.5
diff --git a/pca-main-nokendra.template b/pca-main-nokendra.template
@@ -1,6 +1,6 @@
 AWSTemplateFormatVersion: "2010-09-09"
 
-Description: Amazon Transcribe Post Call Analytics - PCA (v0.2.4) (uksb-1sn29lk73)
+Description: Amazon Transcribe Post Call Analytics - PCA (v0.2.5) (uksb-1sn29lk73)
 
 Parameters:
 

diff --git a/pca-main.template b/pca-main.template
@@ -1,6 +1,6 @@
 AWSTemplateFormatVersion: "2010-09-09"
 
-Description: Amazon Transcribe Post Call Analytics - PCA (v0.2.4) (uksb-1sn29lk73)
+Description: Amazon Transcribe Post Call Analytics - PCA (v0.2.5) (uksb-1sn29lk73)
 
 Parameters:
 

diff --git a/pca-server/cfn/pca-server.template b/pca-server/cfn/pca-server.template
@@ -84,8 +84,8 @@ Outputs:
   RolesForKMSKey:
     Value: !Join
       - ', '
-      - - !Sub '${CopySamples.Outputs.RolesForKMSKey}'
-        - !Sub '${Trigger.Outputs.RolesForKMSKey}'
+      - - !Sub '${Trigger.Outputs.RolesForKMSKey}'
         - !Sub '${PCA.Outputs.RolesForKMSKey}'
         - !Sub '${BulkImport.Outputs.RolesForKMSKey}'
+        - !If [ShouldLoadSampleAudioFiles, !Sub '${CopySamples.Outputs.RolesForKMSKey}', !Ref AWS::NoValue]