Adding s3 bucket for storing cfn template, as it is now too large to work without one #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rstrahan
requested changes
Oct 14, 2024
| @@ -137,7 +137,7 @@ aws cloudformation validate-template --template-url $template > /dev/null || exi | |||
| echo "Outputs" | |||
| echo Template URL: $template | |||
| echo CF Launch URL: https://${region}.console.aws.amazon.com/cloudformation/home?region=${region}#/stacks/create/review?templateURL=${template}\&stackName=PCA | |||
| echo CLI Deploy: aws cloudformation deploy --template-file `pwd`/build/packaged.template --capabilities CAPABILITY_NAMED_IAM CAPABILITY_AUTO_EXPAND --stack-name PCA --parameter-overrides AdminEmail=YOUR_EMAIL | |||
| echo CLI Deploy: aws cloudformation deploy --template-file `pwd`/build/packaged.template --capabilities CAPABILITY_NAMED_IAM CAPABILITY_AUTO_EXPAND --stack-name PCA --s3-bucket ${BUCKET} --parameter-overrides AdminEmail=YOUR_EMAIL | |||
There was a problem hiding this comment.
I'm not in love with writing the template to the root of the specified bucket as a side effect of the deployment.. That might get messy.
An alternative approach could be to change this to use aws cloudformation create-stack instead, which take a [--template-url <value>] parameter which we can point to the template path $template that we already have. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Command Line command recommended at the end of publish.sh no longer works, as the CFN is too large to work without specifying an S3 bucket. Added it to the command